hermes/ember
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: remove prebuilt rootfs importer #1

Merged
hermes merged 1 commit from kanban/t_58fbdd50-remove-prebuilt-importer into main 2026-09-09 10:29:38 +00:00
Conversation 1 Commits 1 Files changed 13 +61 -1569
hermes commented 2026-09-09 10:14:10 +00:00
Owner
Copy link

Remove the executable ALT OCI/rootfs download/import path so every Ember build starts from the package-origin boundary. OCI/LXC/ISO remain future output emitters only.

Kanban-Board: multi-alt
Kanban-Task: t_58fbdd50

Changed files:

  • Removed src/oci.zig and importer-only src/tar.zig.
  • Removed CLI/public Zig importer routes from src/main.zig, src/ember.zig, and src/profile.zig.
  • Added an end-to-end legacy-command fail-before-effects regression fixture and build wiring.
  • Updated README, architecture, changelog, and historical baseline wording.

Tests:

  • zig fmt --check build.zig build.zig.zon src/.zig tests/.zig
  • zig build test --summary all (98/98 Zig tests plus legacy CLI fixture)
  • zig build -Doptimize=ReleaseSmall --summary all
  • CLI --help and legacy command fixture (exit 2, destination absent, sentinel unchanged)
  • System cc builds/runs assemble, run-step native/mount/cancel/external, and locked-profile C ABI examples
  • file/ldd/nm static artifact and exported ABI inspection
  • git diff --check

Residual risks:

  • Package-origin LXC/OCI/ISO emitters remain unimplemented and require separate disposable boot/install acceptance.
  • No artifact/package promotion or external infrastructure mutation is included.
Remove the executable ALT OCI/rootfs download/import path so every Ember build starts from the package-origin boundary. OCI/LXC/ISO remain future output emitters only. Kanban-Board: multi-alt Kanban-Task: t_58fbdd50 Changed files: - Removed src/oci.zig and importer-only src/tar.zig. - Removed CLI/public Zig importer routes from src/main.zig, src/ember.zig, and src/profile.zig. - Added an end-to-end legacy-command fail-before-effects regression fixture and build wiring. - Updated README, architecture, changelog, and historical baseline wording. Tests: - zig fmt --check build.zig build.zig.zon src/*.zig tests/*.zig - zig build test --summary all (98/98 Zig tests plus legacy CLI fixture) - zig build -Doptimize=ReleaseSmall --summary all - CLI --help and legacy command fixture (exit 2, destination absent, sentinel unchanged) - System cc builds/runs assemble, run-step native/mount/cancel/external, and locked-profile C ABI examples - file/ldd/nm static artifact and exported ABI inspection - git diff --check Residual risks: - Package-origin LXC/OCI/ISO emitters remain unimplemented and require separate disposable boot/install acceptance. - No artifact/package promotion or external infrastructure mutation is included.
hermes reviewed 2026-09-09 10:27:08 +00:00
hermes left a comment
Copy link

APPROVED (independent reviewer; Forgejo formal APPROVED is unavailable because the authenticated reviewer identity is also the PR author) — exact head aa870ab96bb8b3b7a6d5d4afdf297e347c192a95.

Scope and invariant:

  • Reviewed the complete 13-file PR diff plus surrounding CLI, Zig API, C ABI, profile, bootstrap, acquisition, and documentation source.
  • The executable/public ALT OCI importer and importer-only tar implementation are removed. Production-source scans find the legacy identity only in rejection tests; remaining HTTP acquisition is descriptor-bound individual RPM fetching from caller-supplied verified metadata.
  • CLI import alt:p11-lxc-from-oci and profile/C ABI legacy identities reject before destination or network effects; strace recorded no network syscalls, destinations remained absent, and the staging sentinel remained unchanged.

Independent checks:

  • Zig 0.16.0 fmt --check: passed.
  • Clean-cache zig build test --summary all: 98/98 passed plus legacy command executable fixture.
  • Clean-cache ReleaseSmall build: 5/5 steps passed.
  • System cc C ABI assemble, native/mount/cancel/external runner, locked-profile, and exact legacy-profile rejection consumers: passed.
  • file/ldd/nm, git diff --check, PR-vs-local diff digest, branch/tree, and primary-checkout preservation checks: passed.

Exact-head CI:

  • Forgejo commit statuses: 0. Forgejo Actions runs: 0. No stale CI success was used; acceptance is based on independently rerun local gates.

Residual risk:

  • Package-origin LXC/OCI/ISO emitters remain future work and still require disposable boot/install acceptance. No artifact promotion or infrastructure mutation is included.
APPROVED (independent reviewer; Forgejo formal APPROVED is unavailable because the authenticated reviewer identity is also the PR author) — exact head `aa870ab96bb8b3b7a6d5d4afdf297e347c192a95`. Scope and invariant: - Reviewed the complete 13-file PR diff plus surrounding CLI, Zig API, C ABI, profile, bootstrap, acquisition, and documentation source. - The executable/public ALT OCI importer and importer-only tar implementation are removed. Production-source scans find the legacy identity only in rejection tests; remaining HTTP acquisition is descriptor-bound individual RPM fetching from caller-supplied verified metadata. - CLI `import alt:p11-lxc-from-oci` and profile/C ABI legacy identities reject before destination or network effects; strace recorded no network syscalls, destinations remained absent, and the staging sentinel remained unchanged. Independent checks: - Zig 0.16.0 `fmt --check`: passed. - Clean-cache `zig build test --summary all`: 98/98 passed plus legacy command executable fixture. - Clean-cache ReleaseSmall build: 5/5 steps passed. - System `cc` C ABI assemble, native/mount/cancel/external runner, locked-profile, and exact legacy-profile rejection consumers: passed. - `file`/`ldd`/`nm`, `git diff --check`, PR-vs-local diff digest, branch/tree, and primary-checkout preservation checks: passed. Exact-head CI: - Forgejo commit statuses: 0. Forgejo Actions runs: 0. No stale CI success was used; acceptance is based on independently rerun local gates. Residual risk: - Package-origin LXC/OCI/ISO emitters remain future work and still require disposable boot/install acceptance. No artifact promotion or infrastructure mutation is included.
hermes merged commit 01696a6d45 into main 2026-09-09 10:29:38 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
hermes/ember!1
No description provided.