From ecece572847f70553f2a2c8f9d754e1f16756986 Mon Sep 17 00:00:00 2001
From: daan <daanl@outlook.com>
Date: Fri, 24 Jan 2020 20:20:43 -0800
Subject: [PATCH] fix bug in committed check in arena allocation

---
 src/arena.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/arena.c b/src/arena.c
index acb92243..55747bb1 100644
--- a/src/arena.c
+++ b/src/arena.c
@@ -107,6 +107,7 @@ static bool mi_arena_alloc(mi_arena_t* arena, size_t blocks, mi_bitmap_index_t*
   size_t idx = mi_atomic_read(&arena->search_idx);  // start from last search
   for (size_t visited = 0; visited < fcount; visited++, idx++) {
     if (idx >= fcount) idx = 0;  // wrap around
+    // try to atomically claim a range of bits
     if (mi_bitmap_try_find_claim_field(arena->blocks_inuse, idx, blocks, bitmap_idx)) {
       mi_atomic_write(&arena->search_idx, idx);  // start search from here next time
       return true;
@@ -135,8 +136,8 @@ static void* mi_arena_alloc_from(mi_arena_t* arena, size_t arena_index, size_t n
     // always committed
     *commit = true;
   }
-  else if (commit) {
-    // ensure commit now
+  else if (*commit) {
+    // arena not committed as a whole, but commit requested: ensure commit now
     bool any_uncommitted;
     mi_bitmap_claim(arena->blocks_committed, arena->field_count, needed_bcount, bitmap_index, &any_uncommitted);
     if (any_uncommitted) {