From 71160e2bac443c0dd35c7ee13993466efcee57b2 Mon Sep 17 00:00:00 2001 From: Daan Date: Tue, 21 Jul 2020 08:49:21 -0700 Subject: [PATCH 1/2] Fix glibc version (issue #270) --- readme.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/readme.md b/readme.md index 7ec20d72..a8aee78c 100644 --- a/readme.md +++ b/readme.md @@ -409,7 +409,7 @@ as [mimalloc-bench](https://github.com/daanx/mimalloc-bench). Testing on a big Amazon EC2 compute instance ([c5.18xlarge](https://aws.amazon.com/ec2/instance-types/#Compute_Optimized)) consisting of a 72 processor Intel Xeon at 3GHz -with 144GiB ECC memory, running Ubuntu 18.04.1 with LibC 2.27 and GCC 7.4.0. +with 144GiB ECC memory, running Ubuntu 18.04.1 with glibc 2.27 and GCC 7.4.0. The measured allocators are _mimalloc_ (xmi, tag:v1.4.0, page reset enabled) and its secure build as _smi_, Google's [_tcmalloc_](https://github.com/gperftools/gperftools) (tc, tag:gperftools-2.7) used in Chrome, @@ -419,7 +419,7 @@ the Intel thread building blocks [allocator](https://github.com/intel/tbb) (tbb, the original scalable [_Hoard_](https://github.com/emeryberger/Hoard) (tag:3.13) allocator by Emery Berger \[1], the memory compacting [_Mesh_](https://github.com/plasma-umass/Mesh) (git:51222e7) allocator by Bobby Powers _et al_ \[8], -and finally the default system allocator (glibc, 2.7.0) (based on _PtMalloc2_). +and finally the default system allocator (glibc, 2.27) (based on _PtMalloc2_). From 1583a73c66b0bf7a2271003240ad7ff2e27f19c7 Mon Sep 17 00:00:00 2001 From: Gal Ben David Date: Thu, 6 Aug 2020 14:29:25 +0300 Subject: [PATCH 2/2] Adding conditional _DEFAULT_SOURCE definition In order to avoid `_DEFAULT_SOURCE` redefinition warnings, I've wrapped the define statement with an `ifndef`. --- src/static.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/static.c b/src/static.c index bf86166d..0b8caa2c 100644 --- a/src/static.c +++ b/src/static.c @@ -4,7 +4,9 @@ This is free software; you can redistribute it and/or modify it under the terms of the MIT license. A copy of the license can be found in the file "LICENSE" at the root of this distribution. -----------------------------------------------------------------------------*/ +#ifndef _DEFAULT_SOURCE #define _DEFAULT_SOURCE +#endif #include "mimalloc.h" #include "mimalloc-internal.h"