add mi_bitmap_popcountN

This commit is contained in:
Daan 2025-06-10 16:11:56 -07:00
parent e2f16d3865
commit 3243a2b105
2 changed files with 54 additions and 0 deletions

View file

@ -256,6 +256,11 @@ static inline bool mi_bfield_atomic_is_xset_mask(mi_xset_t set, const _Atomic(mi
else return mi_bfield_atomic_is_clear_mask(b, mask); else return mi_bfield_atomic_is_clear_mask(b, mask);
} }
// Count bits in a mask
static inline size_t mi_bfield_atomic_popcount_mask(_Atomic(mi_bfield_t)*b, mi_bfield_t mask) {
const mi_bfield_t x = mi_atomic_load_relaxed(b);
return mi_bfield_popcount(x & mask);
}
/* -------------------------------------------------------------------------------- /* --------------------------------------------------------------------------------
@ -366,6 +371,38 @@ static inline bool mi_bchunk_clearN(mi_bchunk_t* chunk, size_t cidx, size_t n, b
return mi_bchunk_xsetN_(MI_BIT_CLEAR, chunk, cidx, n, NULL, maybe_all_clear); return mi_bchunk_xsetN_(MI_BIT_CLEAR, chunk, cidx, n, NULL, maybe_all_clear);
} }
// Check if a sequence of `n` bits within a chunk are all set/cleared.
// This can cross bfield's
mi_decl_noinline static size_t mi_bchunk_popcountN_(mi_bchunk_t* chunk, size_t field_idx, size_t idx, size_t n) {
mi_assert_internal((field_idx*MI_BFIELD_BITS) + idx + n <= MI_BCHUNK_BITS);
size_t count = 0;
while (n > 0) {
size_t m = MI_BFIELD_BITS - idx; // m is the bits to xset in this field
if (m > n) { m = n; }
mi_assert_internal(idx + m <= MI_BFIELD_BITS);
mi_assert_internal(field_idx < MI_BCHUNK_FIELDS);
const size_t mask = mi_bfield_mask(m, idx);
count += mi_bfield_atomic_popcount_mask(&chunk->bfields[field_idx], mask);
// next field
field_idx++;
idx = 0;
n -= m;
}
return count;
}
// Count set bits a sequence of `n` bits.
static inline size_t mi_bchunk_popcountN(mi_bchunk_t* chunk, size_t cidx, size_t n) {
mi_assert_internal(cidx + n <= MI_BCHUNK_BITS);
mi_assert_internal(n>0);
if (n==0) return 0;
const size_t i = cidx / MI_BFIELD_BITS;
const size_t idx = cidx % MI_BFIELD_BITS;
if (n==1) { return (mi_bfield_atomic_is_set(&chunk->bfields[i], idx) ? 1 : 0); }
if (idx + n <= MI_BFIELD_BITS) { return mi_bfield_atomic_popcount_mask(&chunk->bfields[i], mi_bfield_mask(n, idx)); }
return mi_bchunk_popcountN_(chunk, i, idx, n);
}
// ------- mi_bchunk_is_xset --------------------------------------- // ------- mi_bchunk_is_xset ---------------------------------------
@ -1110,6 +1147,20 @@ bool mi_bitmap_clearN(mi_bitmap_t* bitmap, size_t idx, size_t n) {
return were_allset; return were_allset;
} }
// Count bits set in a range of `n` bits.
// `n` cannot cross chunk boundaries (and `n <= MI_BCHUNK_BITS`)!
size_t mi_bitmap_popcountN( mi_bitmap_t* bitmap, size_t idx, size_t n) {
mi_assert_internal(n>0);
mi_assert_internal(n<=MI_BCHUNK_BITS);
const size_t chunk_idx = idx / MI_BCHUNK_BITS;
const size_t cidx = idx % MI_BCHUNK_BITS;
mi_assert_internal(cidx + n <= MI_BCHUNK_BITS); // don't cross chunks (for now)
mi_assert_internal(chunk_idx < mi_bitmap_chunk_count(bitmap));
if (cidx + n > MI_BCHUNK_BITS) { n = MI_BCHUNK_BITS - cidx; } // paranoia
return mi_bchunk_popcountN(&bitmap->chunks[chunk_idx], cidx, n);
}
// Set/clear a bit in the bitmap; returns `true` if atomically transitioned from 0 to 1 (or 1 to 0) // Set/clear a bit in the bitmap; returns `true` if atomically transitioned from 0 to 1 (or 1 to 0)
bool mi_bitmap_set(mi_bitmap_t* bitmap, size_t idx) { bool mi_bitmap_set(mi_bitmap_t* bitmap, size_t idx) {

View file

@ -219,6 +219,9 @@ bool _mi_bitmap_forall_set(mi_bitmap_t* bitmap, mi_forall_set_fun_t* visit, mi_a
bool _mi_bitmap_forall_setc_ranges(mi_bitmap_t* bitmap, mi_forall_set_fun_t* visit, mi_arena_t* arena, void* arg); bool _mi_bitmap_forall_setc_ranges(mi_bitmap_t* bitmap, mi_forall_set_fun_t* visit, mi_arena_t* arena, void* arg);
// Count all set bits in given range in the bitmap. (cannot cross chunks)
size_t mi_bitmap_popcountN( mi_bitmap_t* bitmap, size_t idx, size_t n);
/* ---------------------------------------------------------------------------- /* ----------------------------------------------------------------------------
Binned concurrent bitmap Binned concurrent bitmap
Assigns a size class to each chunk such that small blocks don't cause too Assigns a size class to each chunk such that small blocks don't cause too